Guzzle http client fixes

basvandorst / StravaPHP

Strava API REST client with OAuth authentication

MIT License

184 stars 67 forks source link

Guzzle http client fixes #44

Closed vredeling closed 4 years ago

vredeling commented 6 years ago

Strava endpoint needs a trailing slash for Guzzle http client. Otherwise the client will revert to https://www.strava.com/api/ and all api requests will return a 404.

vredeling commented 5 years ago

The addition in #48 is also required.

vredeling commented 5 years ago

Merged #45 and #48

vredeling commented 5 years ago

@fbonzon could you take a look at #44 #45 #47 #48 and #49? I've contacted @basvandorst who is not able to review these issues and pr's currently.

fbonzon commented 5 years ago

Hi @vredeling. I'm not able either to review these PRs in the immediate future, unfortunately. I'll get back to active work here asap.

vredeling commented 5 years ago

@fbonzon thanks for the reply. FTTB I'll continue working in my own fork.

natatkinson commented 5 years ago

Please merge this into production!

beararmy commented 5 years ago

Damn it man, merge it already!

vredeling commented 4 years ago

@natatkinson @beararmy I intend to continue development of the Strava PHP library on my fork. See: https://github.com/vredeling/StravaPHP and https://packagist.org/packages/vredeling/stravaphp