PHPStan - Githubissues

basvandorst / StravaPHP

Strava API REST client with OAuth authentication

MIT License

184 stars 67 forks source link

PHPStan #76

Closed MGatner closed 2 years ago

MGatner commented 2 years ago

Adds PHPStan for static analysis
Implements analysis through level 5
Enables GitHub Action workflow, including new analysis step

djjavo commented 2 years ago

Looks good to me, not sure I have the required privileges to approve though. @basvandorst Or @vredeling can you assist?

MGatner commented 2 years ago

The failures are from merging PHPUnit 9 in, since PHPUnit_Framework_MockObject_MockObject no longer exists. Removing the docblock typehint should fix it, or finding the actual return of the mock.

vredeling commented 2 years ago

Yes, needs a bit of work still. Perhaps later this evening I can find some time to update the PR. Feel free to submit some updates yourself @MGatner.