search

basvandorst / StravaPHP

Strava API REST client with OAuth authentication
MIT License
184 stars 67 forks source link

Incorrect parameter name for getSegmentEffort #8

Closed AntonCooper closed 8 years ago

AntonCooper commented 9 years ago 
    $parameters = array(
        'bounds' => $athlete_id,
        'start_date_local' => $start_date_local,
        'end_date_local' => $end_date_local,
        'page' => $page,
        'per_page' => $per_page
    );

Should be:

    $parameters = array(
        'athlete_id' => $athlete_id,
        'start_date_local' => $start_date_local,
        'end_date_local' => $end_date_local,
        'page' => $page,
        'per_page' => $per_page
    );
dsas commented 8 years ago

This has been fixed by https://github.com/basvandorst/StravaPHP/pull/9

basvandorst commented 8 years ago

Thanks @dsas!

@AntonCooper This piece of code is now in the master branch. This weekend or next week I'm going to create and test the 1.1.0 branch.