basveeling / wavenet

Keras WaveNet implementation
https://soundcloud.com/basveeling/wavenet-sample
1.06k stars 219 forks source link

Fix: Skip connections have separate 1x1 convolutions from the residual output. #10

Closed basveeling closed 7 years ago

basveeling commented 7 years ago

After some correspondence with the authors it turns out that the skip connections are parameterized by a 1x1 convolution, separate from the one that goes into the add block. This should be an easy fix but could potentially explain poor training results before.

jfsantos commented 7 years ago

All this means is that each skip_out should be the output of another Conv1D layer instead of being the same as x, right? I'll submit a PR soon.