saemideluxe
commented
2 years ago Okay, this is quite a big one. However, in a lot of places there happend just small changes due to how the API changed. The relevant changes are mainly in bread.layout.components.forms. That package is not perfect yet, I see quite a few improvments on how we could restructure it. But we have to get this refactoring through at some point.
The main points of this refactoring were:
- Use better, more consistent names. Especially what formerly was called "FormField" is actually considered a "Widget" in the Django world, widgets are responsible to render a form field, the formfield itself does not have "knowledge" about representation. This is important for us to realize, as we normally only want to modify widgets (to be "carbonized" or similar) and not the handling of fields. This attitude is now much better reflected in the naming and structure.
- Consistent API of how widgets are created/instantiated. This could likely be written in a better way, but we have now a good place to start from. All widget init methods accept the same minimal set of parameters.
- Widgets can now be better instantiated independent from Django forms, directly from their class or via a function (
generate_widget_element). Normally the later should be used, as it will create a fully "carbonized" widget. However, sometimes the "pure" version of the widget is desired. - A function (
generate_widget_element) which can be used to correctly generate a widget that depends on a Django form field. The function will take care to pass all relevant settings from the Django form field to the widget. The function tries to mimick the vanilla Django widget instantiation as closely as possible. - Add some things which have been missing since quite some time like: Clearable file input and radio selects
Work in progress