search

basxsoftwareassociation / bread

Engine to create database applications based on Django and the IBM Carbon Design System
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

Missing Tab content fix #122

Closed dward2nd closed 2 years ago

dward2nd commented 2 years ago

According to this issue in basxconnect's repo, this is because Tabs depend too much on the cookie value. So, the solution is to check the cookie value before it's been used.

dward2nd commented 2 years ago

I think neither is better in terms of user experience or performance. So I'll leave it to your decision then.

saemideluxe commented 2 years ago

Okay, pushed the JS fix. Can you test this too in your environment?

saemideluxe commented 2 years ago

For you information: the "onload" attribute is not javascript/DOM standard for most HTML elements. However, because it is often usefull to do some initialization when writing standalone interface components we do call the onload attribute artifically with bread.

dward2nd commented 2 years ago

Works normally as well as the cookie one.

saemideluxe commented 2 years ago

Ok, thanks.