search

basxsoftwareassociation / bread

Engine to create database applications based on Django and the IBM Carbon Design System
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

add: dataclass DataTableColumn instead of magic tuple #29

Closed wipascal closed 3 years ago

wipascal commented 3 years ago

I personally think tuples are not the best thing for public APIs. So I created a class instead of the tuple.

saemideluxe commented 3 years ago

I personally think tuples are not the best thing for public APIs. So I created a class instead of the tuple.

Agreed!

saemideluxe commented 3 years ago

Good job with all the small improvments inside the datatables code.

wipascal commented 3 years ago

I made the mistake to merge a PR in basxconnect which depends on that one... So it would be good to merge it soon :)

saemideluxe commented 3 years ago

I made the mistake to merge a PR in basxconnect which depends on that one... So it would be good to merge it soon :)

Np, if you blocks your workflow feel free to force-merge next time.