search

basxsoftwareassociation / bread

Engine to create database applications based on Django and the IBM Carbon Design System
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

make "lg" the default breakpoint for columns #61

Closed wipascal closed 3 years ago

wipascal commented 3 years ago

It just feels awkward to have to type "lg" every time since we only currently target deskop anyway. This PR doesn't break any usages of other breakpoints than "lg".

saemideluxe commented 3 years ago

At the point where I was using breakpoints, they would not work as expected if the width was given. Does that work now as expected?

wipascal commented 3 years ago

At the point where I was using breakpoints, they would not work as expected if the width was given. Does that work now as expected?

I would say so. I can definitely use width in order to have different widths of columns...

saemideluxe commented 3 years ago

Sorry, I meant "if the width was not given" ;)

wipascal commented 3 years ago

Ah yes, I think then setting a breakpoint does not have any effect. The default "lg" will only have an effect on the produced html if a width was given.

saemideluxe commented 3 years ago

Ah right. I was only concerned for users trying to set the width without a breakpoint then then not getting any results. But with having a default breakpoint this is no longer a concern.