basysKom / RiveQtQuickPlugin

A Qt / QtQuick Renderer to draw Rive Animations in QML.
50 stars 6 forks source link

Building on Windows #63

Open madoodia opened 1 year ago

madoodia commented 1 year ago

Hello Developer Colleagues

This is a PR for my experimental building the whole package on Windows10, I hope it goes you well,.

This will help people who want to build the package in Windows with cl.exe as the compiler.

I've created a BUILDING.md file and explained what they need to do.

During the build process I've encountered a bunch of errors that tried to fix them, for example using /bigobj flag in the compiler for HarfBuzz package. that is added to the cmake builder.

and I should say I've build the application against:

...
spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ZnQRKR\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ZnQRKR\qsb_spv_temp_out
Failed to run spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ZnQRKR\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ZnQRKR\qsb_spv_temp_out: Process failed to start: The system cannot find the file specified.
fxc /nologo /E main /T ps_5_0 /Fo C:\Users\Chapool\AppData\Local\Temp\qsb-Fhslhc\qsb_hlsl_temp_out C:\Users\Chapool\AppData\Local\Temp\qsb-Fhslhc\qsb_hlsl_temp
[ 87%] Generating .qsb/shaders/qt6/blendRiveTextureNode.vert.qsb
spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp_out
Failed to run spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp_out: Process failed to start: The system cannot find the file specified.
spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp_out
Failed to run spirv-opt -O C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp -o C:\Users\Chapool\AppData\Local\Temp\qsb-ogCHaB\qsb_spv_temp_out: Process failed to start: The system cannot find the file specified.
fxc /nologo /E main /T vs_5_0 /Fo C:\Users\Chapool\AppData\Local\Temp\qsb-VVogop\qsb_hlsl_temp_out C:\Users\Chapool\AppData\Local\Temp\qsb-VVogop\qsb_hlsl_temp
fxc /nologo /E main /T vs_5_0 /Fo C:\Users\Chapool\AppData\Local\Temp\qsb-VVogop\qsb_hlsl_temp_out C:\Users\Chapool\AppData\Local\Temp\qsb-VVogop\qsb_hlsl_temp
...

And the result is a little bit weird that I showed in the picture.

image

btw, I liked the way you build the rive-cpp, really I did!

thanks

jebos commented 1 year ago

Hey, thanks for the PR! Right now, we're in the process of updating RIVE to its latest version. Once that's done, we'll dive into your PR for a thorough review. We're target on merging it in, so that's exciting! šŸ˜Š

As for the clipping issue you brought up, it's definitely on our to-do list and we'll be taking a closer look at it soon.

Cheers! šŸŽ‰

mitchcurtis commented 1 month ago

Has there been any progress on this, @jebos?

jebos commented 1 month ago

Hello, we decided to keep the PR open here for everyone to take a look at. But also not to merge it for now.

@mitchcurtis are you still facing similar issues as noted here?

mitchcurtis commented 1 month ago

I created https://github.com/basysKom/RiveQtQuickPlugin/issues/52, and was waiting for an answer there when @madoodia commented that his patch fixed my issue.