basz / SlmLocale

Auto detection of locale through different strategies for Zend Framework 2
Other
67 stars 34 forks source link

Don't redirect to default locale #103

Closed kokspflanze closed 5 years ago

kokspflanze commented 5 years ago

possible solution for #41

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.5%) to 82.857% when pulling e6d494d991d301f39e9b05de72da38b0fdcc24e3 on kokspflanze:feature/default_locale into 2a8a0a66eced2cdddd60462ef62aa3df62002653 on basz:master.

kokspflanze commented 5 years ago

@svycka added some tests, these are enough or you think that i missed smth?

svycka commented 5 years ago

whoops this should have been merged to develop

kokspflanze commented 5 years ago

i can send you a revert commit in the evening for master if that is okay for you.

svycka commented 5 years ago

@kokspflanze I already fixed and released 0.4.1 I hope everything will be okay

kokspflanze commented 5 years ago

@svycka okay, i will add some more pull requests, next days. these will go in develop =)

svycka commented 5 years ago

okay, :D that was a bit my fault because I forgot about develop branch when I saw 0.y.x version. I don't have develop branch unless it's already 1.0.0. But I guess we can release 1.0.0