search

basz / SlmLocale

Auto detection of locale through different strategies for Zend Framework 2
Other
67 stars 34 forks source link

fix locale url change, from default locale to other locale #105

Closed kokspflanze closed 5 years ago

kokspflanze commented 5 years ago

sry had a little bug, with locale url change generation

current url: / url for en: /en

current url: /currency/foobar url for en: /en/foobar // wrong currency was missing

that i fixed with this change

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.3%) to 84.211% when pulling 0abec276300fa9379941c9913d0deb72af0e65bb on kokspflanze:feature/default_locale into ddc7f55113e5858226c4b42b4551fec517b51046 on basz:master.

kokspflanze commented 5 years ago

what you mean with basePath?

if you access the page with directories? like page stay in /page/public and you have to call it with page/public ? because that was not working before, but i want to add the support for this too^^

svycka commented 5 years ago

Yes, I mean https://exampe.com/base/path/en/foo/bar I am not sure this worked before. I don't use this maybe you are right it does not work but would be nice if you could make it work

svycka commented 5 years ago

If it will be too hard to support basepath I guess we can throw an exception if base bath is set and we don't support it if it does not work anyway. Anyway, I don't know if anyone using this.

kokspflanze commented 5 years ago

i was using it^^ and first i was searching for the error^^ i will add a way to support it no way, i hope until end of next week.

svycka commented 5 years ago

@kokspflanze should I merge this or you are still working with this working?

kokspflanze commented 5 years ago

@svycka let it open, as reminder for me todo the base stuff =) i will do this this week, not sure today or friday.

kokspflanze commented 5 years ago

resolve now https://github.com/basz/SlmLocale/issues/40 https://github.com/basz/SlmLocale/issues/47

svycka commented 5 years ago

okay :ship: