UriPathStrategy set Router's baseurl

[basz]

Hello, I enjoyed working on the UriPathStrategy yesterday and the discussion is stirred.

I was thinking about the routing problems that I encountered yesterday when combining this module with AssetManager.

Even though personally I would prefer pre-routing asset checking, SlmLocale's should not rely on such behavior - and the fact is the current implementation updated the baseurl of the router to have existing routes localized for every request. This may not be desired behavior.

An application developer would like to have to define what exactly which routes are localized and which are not - the dynamic assets example is just one manifestation. Having paths of my project that aren't localized at all would be another...

So perhaps we should take this as a queue that there is some deeper problem with messing with the router the way SlmLocale/UriPathStrategy does.

Intuitively it feels to me that the UriPathStrategy can still be used as a detection meganism - but that - since SlmLocale is planned for ZF2 integration anyway - anything to do with localized routes should be handled by the router itself. That would then include the HostStrategy and perhaps other.

Unfortunately I am too unfamiliar with the Router process to be authoritative here -but intuitively it feels to me that anything to do with routing should in fact be handled by the router. If that means that changes should be made to the the router a special route or plugin or whatever so be it.

How to do this I leave up to smarter people :-)

thanks

[DASPRiD]

I'll investigate this over the weekend.

[basz]

about to be closed: https://github.com/RWOverdijk/AssetManager/issues/27#issuecomment-9100319

[juriansluiman]

@basz I will test your PR #5 and merge then. I think for now the code is good to go, despite of the problems in conjunction with the asset manager.

I still aim to implement this codebase into ZF2.1 and I think this issue will be addressed then again. I am not sure a white or blacklist would resolve the problem, but when this gets into the Zend codebase (if that happens at all) there are more brains looking at this, so I hope new ideas will be proposed then. For now, I have noted the problem and -as I do not see a good solution- mark this as a "wontfix".

[basz]

Agreed, after thinking on it more I believe the only issue is doing ->baseuri in view scripts returning a locale in the URL that you might not want for assets. But I would not know how to work around that without making the router locale aware.

I think you mentioned a few style changes regarding method_exists vs instanceof that you preferred.

Thx

Op 10 okt. 2012 om 16:24 heeft Jurian Sluiman notifications@github.com het volgende geschreven:

@basz I will test your PR #5 and merge then. I think for now the code is good to go, despite of the problems in conjunction with the asset manager.

I still aim to implement this codebase into ZF2.1 and I think this issue will be addressed then again. I am not sure a white or blacklist would resolve the problem, but when this gets into the Zend codebase (if that happens at all) there are more brains looking at this, so I hope new ideas will be proposed then. For now, I have noted the problem and -as I do not see a good solution- mark this as a "wontfix".

— Reply to this email directly or view it on GitHub.

[shinesoftware]

@basz have you solved in any way the asset manager issue? I have the same issue! :(

[basz]

@shinesoftware if ignoring the problem counts as 'solved' then yes :-p

[shinesoftware]

@basz so I have solved it too :smiley:

[basz]

I don't think it can be solved and have accepted it as a limitation of how these particular modules work together.

[shinesoftware]

how have you solved the language router configuration? http://stackoverflow.com/questions/28498396/zf2-language-routes