search

basz / SlmLocale

Auto detection of locale through different strategies for Zend Framework 2
Other
67 stars 34 forks source link

create correct urls for locale menu with host strategy #61

Closed prolic closed 10 years ago

prolic commented 10 years ago

requires https://github.com/juriansluiman/SlmLocale/pull/60

prolic commented 10 years ago

ping @juriansluiman

juriansluiman commented 10 years ago

:+1: really good to add the assemble() for the host strategy too, thanks :)

I just need a little bit of time to check the idea. Also, I would prefer to have this feature covered in a unit test, but there is nothering covered yet for this strategy. So if you're able to create a test case for this strategy and add the assembling test, I would be very pleased. Otherwise somewhere next week I set up the coverage and directly add your assemble feature as well.

prolic commented 10 years ago

ping @juriansluiman I added tests for the host strategy.

juriansluiman commented 10 years ago

Awesome!!!

juriansluiman commented 10 years ago

@prolic I haven't tagged a new release yet. I want to tackle more open standing PRs / issues these days and tag a stable release. So please use @dev or dev-master for now.