Closed koseduhemak closed 6 years ago
Why is travis failing? I am not experienced in pull requests... Please provide some hint so I can fix...
Cause you have code style errors.
See log: https://travis-ci.org/basz/SlmLocale/jobs/298633316
You are able to run those checks yourself before committing with this command
vendor/bin/php-cs-fixer fix -v --diff --dry-run
One of your tests isnt passing
By fixing code style issues I accidentally removed a line of code... Now everything should be working.
refactored here https://github.com/basz/SlmLocale/pull/97
Fixing problems of issue #67, which describes problems by using SlmLocale in combination with the famous https://github.com/RWOverdijk/AssetManager module.
Problem
When using asset manager to manage assets in your project, uris of assets getting rewritten to locale aware uris. This leads to 404 not found, because the assetmanager is not able to resolve them anymore. Therefore we need a strategy to cope such uris.
Solution
The provided AssetStrategy checks if the requested uri is an asset and prevents url rewriting through other strategies.
Example config