bat-serjo / PyIface

Python module to control network interfaces.
GNU General Public License v3.0
21 stars 10 forks source link

Fix imports for Python2 and Python3 #9

Closed alexvasiu closed 6 years ago

alexvasiu commented 6 years ago

I found a unique way that imports will work on Python2 and also on Python3. Signed-off-by: Alexandru Vasiu alexandru.vasiu@ni.com

bat-serjo commented 6 years ago

Feel free to build and upload 0.0.4 I updated the setup.py but you'll have to re-update it to reflect py2

alexvasiu commented 6 years ago

@bat-serjo Yep, but I think I should build as 0.0.3 and update the package in pip because if I'll create 0.0.4 version, 0.0.3 will remain in pip and it's a version that doesn't work because of these import errors. Then I'll also add pyiface upstream in meta-openembedded

bat-serjo commented 6 years ago

No, put 0.0.4 and remove 0.0.3 so that it is no longer served. If you replace 0.0.3 some user might have the old 0.0.3 version and he won't know how to upgrade to the new one.

2018-03-07 22:26 GMT+02:00 Vasiu Alexandru notifications@github.com:

@bat-serjo https://github.com/bat-serjo Yep, but I think I should build as 0.0.3 and update the package in pip because if I'll create 0.0.4 version, 0.0.3 will remain in pip and it's a version that doesn't work because of these import errors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bat-serjo/PyIface/pull/9#issuecomment-371273104, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdnLa4abU3FkvKb98k6lDORYrIif-Vkks5tcEJrgaJpZM4SgDfH .

alexvasiu commented 6 years ago

Ok, I'll do like that ;) also to match py2 and py3, python_requires should be >=2.

bat-serjo commented 6 years ago

True it should.

2018-03-08 0:00 GMT+02:00 Vasiu Alexandru notifications@github.com:

Ok, I'll do like that ;) also to match py2 and py3, python_requires should be >=2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bat-serjo/PyIface/pull/9#issuecomment-371300200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdnLZO9-kjKe7qqHSIpu5er5EQ_9jczks5tcFh2gaJpZM4SgDfH .

bat-serjo commented 6 years ago

But make it >=2.7 cause i think there are syntax problems with older py2 versions.

2018-03-08 11:16 GMT+02:00 Sergei Kostov bat.serjo@gmail.com:

True it should.

2018-03-08 0:00 GMT+02:00 Vasiu Alexandru notifications@github.com:

Ok, I'll do like that ;) also to match py2 and py3, python_requires should be >=2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bat-serjo/PyIface/pull/9#issuecomment-371300200, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdnLZO9-kjKe7qqHSIpu5er5EQ_9jczks5tcFh2gaJpZM4SgDfH .

alexvasiu commented 6 years ago

@bat-serjo Ok. Can you please merge this into master?