search

bat / BAT.jl

A Bayesian Analysis Toolkit in Julia
Other
198 stars 30 forks source link

Rename transformed (Update for Measure terminology) #441

Open Micki-D opened 3 months ago

Micki-D commented 3 months ago

Updates the original PR #409 with the new measure terminology.

Micki-D commented 3 months ago

So the failing tests are due to errors in the generation of viable MCMC chains. But I am unsure if this is due to issues with the Measure terminology or due to issues in the original PR #409. Were there any known issues with the transformed MCMC algorithms @Cornelius-G ? Thanks!

Micki-D commented 3 months ago

Also, @oschulz is there a convention for when to use 'X_density' or 'X_measure' or 'm' as variable names?
It's unclear to me from the existing code. Thanks!

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 9.83146% with 642 lines in your changes missing coverage. Please review.

Project coverage is 42.60%. Comparing base (67ac2bf) to head (427481f). Report is 2 commits behind head on main.

:exclamation: Current head 427481f differs from pull request most recent head 189c285

Please upload reports for the commit 189c285 to get more accurate results.

Files Patch % Lines
src/samplers/transformed_mcmc/mcmc_iterate.jl 0.00% 126 Missing :warning:
src/samplers/transformed_mcmc/chain_pool_init.jl 0.00% 111 Missing :warning:
src/samplers/transformed_mcmc/mcmc_convergence.jl 0.00% 56 Missing :warning:
src/samplers/transformed_mcmc/mcmc_stats.jl 0.00% 56 Missing :warning:
...sformed_mcmc/mcmc_tuning/mcmc_proposalcov_tuner.jl 0.00% 54 Missing :warning:
src/samplers/transformed_mcmc/proposaldist.jl 0.00% 43 Missing :warning:
...rc/samplers/transformed_mcmc/multi_cycle_burnin.jl 0.00% 37 Missing :warning:
src/samplers/transformed_mcmc/mcmc_algorithm.jl 0.00% 30 Missing :warning:
...ers/transformed_mcmc/mcmc_tuning/mcmc_ram_tuner.jl 0.00% 30 Missing :warning:
src/samplers/transformed_mcmc/mcmc_sample.jl 0.00% 29 Missing :warning:
... and 8 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #441 +/- ## ========================================== - Coverage 47.26% 42.60% -4.67% ========================================== Files 111 127 +16 Lines 5385 6068 +683 ========================================== + Hits 2545 2585 +40 - Misses 2840 3483 +643 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.