search

batchnz / craft-commerce-untitled

A Craft Commerce plugin for minting variants based on field values
MIT License
0 stars 1 forks source link

Improve terminology #13

Open moacode opened 3 years ago

moacode commented 3 years ago

We need to ensure consistent terminology is used across the front end generation UI. A classic example is sku vs SKU. Using Craft's JS translations could be a good option here.

moacode commented 3 years ago

Estimate: A few hours if the above approach can be used.

moacode commented 3 years ago

@judereid I've added translations which can be found in src/translations/en/craft-commerce-untitled.php. Note that the translation text needs to be loaded into the view which is done from the registerAssetFiles() method within the asset bundle (src/assetbundles/craftcommerceuntitled/CraftCommerceUntitledAsset.php).

At the moment I've just "translated" sku --> SKU but there may be other terms we need to translate so will leave this open until the plugin is finalised.