search

batchnz / craft-commerce-untitled

A Craft Commerce plugin for minting variants based on field values
MIT License
0 stars 1 forks source link

Reliance on craft-twigpack in production #6

Closed moacode closed 3 years ago

moacode commented 3 years ago

While Twigpack has been great for development, I suspect we'll need to remove the composer dependency and reliance in production mode as it's unreasonable to force users to have the plugin installed just to use our plugin.

As we're publishing the dist assets via a Yii Asset Bundle which has it's own form of cache busting, we can configure Webpack to spit out a non-hashed filename during a production build and load that file via the Asset Bundle.

moacode commented 3 years ago

Estimate: 1 hour to perform some tests and update Webpack configuration.

moacode commented 3 years ago

This has been resolved.