search

batchu / owasp-esapi-java

Automatically exported from code.google.com/p/owasp-esapi-java
0 stars 0 forks source link

Tests on windows expect SYSROOT=c:\Windows #101

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
From Mungo Carstairs:

I changed "Windows" to "WINNT" in
ValidatorTest.testIsValidDirectoryPath()
ValidatorTest.testIsValidFileUpload()
ExecutorTest.testExecuteWindowsSystemCommand()

Original issue reported on code.google.com by schal...@darkmist.net on 30 Jan 2010 at 3:39

GoogleCodeExporter commented 8 years ago 
java 1.4's System#getenv(String) throws a java.lang.Error so 
getenv("SYSTEMROOT")
doesn't help here.

Original comment by schal...@darkmist.net on 30 Jan 2010 at 3:40

GoogleCodeExporter commented 8 years ago 
I believe this to be fixed in the 1.4 branch in revision 1131. If folks could 
give it
a try I would appreciate it.

I'd like to leave this issue open as a reminder to me to get these changes 
forward
ported to the 2.0 branch.

Thanks!

Original comment by schal...@darkmist.net on 7 Feb 2010 at 4:09

GoogleCodeExporter commented 8 years ago 
Brent Shikoski pointed out that I missed "C:\\WINDOWS\\system32" in
ValidatorTest.testIsValidFileUpload(). I'll look into this but not tonight...

Original comment by schal...@darkmist.net on 8 Feb 2010 at 3:59

GoogleCodeExporter commented 8 years ago 
This is fixed in revision 1135

Original comment by schal...@darkmist.net on 27 Feb 2010 at 1:09