search

batchu / owasp-esapi-java

Automatically exported from code.google.com/p/owasp-esapi-java
0 stars 0 forks source link

defect: tld for JavaScript & HTMLAttribute encoding references wrong code #37

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I feel stupid about missing this. The tld specifies that
encodeForJavaScript and encodeForHTMLAttribute use the EncodeForHTMLTag
class instead of the EncodeForJavaScriptHTMLTag and
EncodeForHTMLAttributeTag classes respectively.

I checked the tld from 1.4 and the issue exists there as well 

The attached patch fixes the issue. Note that it assumes that the esapi.tld
has been moved to src/main/resources/META-INF (issue 35). The patch is
against trunk revision 688 + issue 35's change.

I've tested the patch in tomcat 6...

Original issue reported on code.google.com by schal...@darkmist.net on 15 Oct 2009 at 8:54

GoogleCodeExporter commented 8 years ago 
Blasted... I meant issue 36 above...

Original comment by schal...@darkmist.net on 15 Oct 2009 at 8:55

GoogleCodeExporter commented 8 years ago 
I just noticed that issue 35 (refactor) got applied. Give me a few and I'll add 
a new
patch.

Original comment by schal...@darkmist.net on 15 Oct 2009 at 9:16

GoogleCodeExporter commented 8 years ago 
Patch against trunk revision 690 after patch/mv in issue 36. Tested in tomcat 6.

Original comment by schal...@darkmist.net on 15 Oct 2009 at 9:34

Attachments:

GoogleCodeExporter commented 8 years ago 
I will look at this and apply changes after the merge this weekend for RC3

Original comment by chrisisbeef on 23 Oct 2009 at 4:16

GoogleCodeExporter commented 8 years ago

Original comment by chrisisbeef on 23 Oct 2009 at 4:16

GoogleCodeExporter commented 8 years ago

Original comment by chrisisbeef on 29 Oct 2009 at 5:12

GoogleCodeExporter commented 8 years ago

Original comment by chrisisbeef on 29 Oct 2009 at 5:12

GoogleCodeExporter commented 8 years ago 
Patch applied in revision 744

Original comment by schal...@darkmist.net on 4 Nov 2009 at 7:28