dhalperi
commented
1 year ago Do not do this until the question is done.
Right now it's in prototype and not stable API
On Fri, Dec 9, 2022 at 23:32 ratulm @.***> wrote:
Couple of things: 1/ The question should show up here: https://pybatfish.readthedocs.io/en/latest/notebooks/differentialQuestions.html 2/ Add to this notebook ( https://github.com/batfish/pybatfish/blob/master/jupyter_notebooks/Analyzing%20Routing%20Policies.ipynb) or create a separate one showing usage
1 is higher priority. Once that is done, PR #868 https://github.com/batfish/pybatfish/pull/868 can be reverted.
PS: Consider making the interface of the question consistent with compareFilters first.
— Reply to this email directly, view it on GitHub https://github.com/batfish/pybatfish/issues/869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAQT47PPPEZ5FMPQBJOTTWMQWYLANCNFSM6AAAAAAS2DGQQM . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Couple of things: 1/ The question should show up here: https://pybatfish.readthedocs.io/en/latest/notebooks/differentialQuestions.html 2/ Add to this notebook (https://github.com/batfish/pybatfish/blob/master/jupyter_notebooks/Analyzing%20Routing%20Policies.ipynb) or create a separate one showing usage
1 is higher priority. Once that is done, PR https://github.com/batfish/pybatfish/pull/868 can be reverted.
PS: Consider making the interface of the question consistent with compareFilters first.