search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
208 stars 51 forks source link

pybatfish: remove tests of deprecated API #871

Closed dhalperi closed 1 year ago

dhalperi commented 1 year ago

that API is gone, after all.

batfish-bot commented 1 year ago

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #871 (abe6f6b) into master (5ee6d27) will decrease coverage by 1.40%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #871 +/- ## ========================================== - Coverage 87.51% 86.11% -1.41% ========================================== Files 30 30 Lines 3989 3989 Branches 645 645 ========================================== - Hits 3491 3435 -56 - Misses 351 406 +55 - Partials 147 148 +1 ``` | [Impacted Files](https://codecov.io/gh/batfish/pybatfish/pull/871?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/client/resthelper.py](https://codecov.io/gh/batfish/pybatfish/pull/871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9yZXN0aGVscGVyLnB5) | `47.72% <0.00%> (-27.28%)` | :arrow_down: | | [pybatfish/client/internal.py](https://codecov.io/gh/batfish/pybatfish/pull/871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9pbnRlcm5hbC5weQ==) | `70.83% <0.00%> (-12.50%)` | :arrow_down: | | [pybatfish/client/workhelper.py](https://codecov.io/gh/batfish/pybatfish/pull/871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC93b3JraGVscGVyLnB5) | `65.76% <0.00%> (-10.87%)` | :arrow_down: | | [pybatfish/client/session.py](https://codecov.io/gh/batfish/pybatfish/pull/871/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9zZXNzaW9uLnB5) | `75.99% <0.00%> (-4.90%)` | :arrow_down: |