search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
214 stars 52 forks source link

Session: flip enable_diagnostics to False #880

Closed dhalperi closed 1 year ago

dhalperi commented 1 year ago

Stop advertising this functionality.

commit-id:dbbb939f

batfish-bot commented 1 year ago

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #880 (3e8b0d6) into master (8e9adb5) will decrease coverage by 0.13%. The diff coverage is 100.00%.

:exclamation: Current head 3e8b0d6 differs from pull request most recent head 7c7fa42. Consider uploading reports for the commit 7c7fa42 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #880 +/- ## ========================================== - Coverage 86.12% 85.99% -0.13% ========================================== Files 30 30 Lines 3992 3992 Branches 665 665 ========================================== - Hits 3438 3433 -5 - Misses 406 412 +6 + Partials 148 147 -1 ``` | [Impacted Files](https://codecov.io/gh/batfish/pybatfish/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/client/session.py](https://codecov.io/gh/batfish/pybatfish/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9zZXNzaW9uLnB5) | `75.75% <100.00%> (-0.24%)` | :arrow_down: | | [pybatfish/client/\_diagnostics.py](https://codecov.io/gh/batfish/pybatfish/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9fZGlhZ25vc3RpY3MucHk=) | `74.31% <0.00%> (-3.67%)` | :arrow_down: |