batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
208 stars 51 forks source link

Update configProperties questions notebook #888

Closed ratulm closed 1 year ago

ratulm commented 1 year ago

Need to update after https://github.com/batfish/batfish/pull/8735

The id field in the notebook cells was auto-generated despite a brand new Python 3.9 environment with only pybatfish, requriments.txt and docs/requirements.txt.

Update: Happens with Python 3.7 as well. (Some notebook dependency must have changed.)

batfish-bot commented 1 year ago

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #888 (f6c33a9) into master (ded296e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f6c33a9 differs from pull request most recent head 7150417. Consider uploading reports for the commit 7150417 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #888 +/- ## ======================================= Coverage 85.99% 85.99% ======================================= Files 30 30 Lines 3992 3992 Branches 665 665 ======================================= Hits 3433 3433 Misses 412 412 Partials 147 147 ```