search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
214 stars 52 forks source link

Updated representation of next-hops in routes #889

Closed millstein closed 1 year ago

millstein commented 1 year ago

Updates the pybatfish API and corresponding notebooks to support the new representation of next hops in BGP routes as a result of Batfish PR #8740

batfish-bot commented 1 year ago

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #889 (66abfe4) into master (6147cc6) will decrease coverage by 0.56%. The diff coverage is 57.14%.

:exclamation: Current head 66abfe4 differs from pull request most recent head 5c02174. Consider uploading reports for the commit 5c02174 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #889 +/- ## ========================================== - Coverage 85.99% 85.44% -0.56% ========================================== Files 30 30 Lines 3992 4067 +75 Branches 665 679 +14 ========================================== + Hits 3433 3475 +42 - Misses 412 443 +31 - Partials 147 149 +2 ``` | [Files Changed](https://app.codecov.io/gh/batfish/pybatfish/pull/889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/datamodel/route.py](https://app.codecov.io/gh/batfish/pybatfish/pull/889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2RhdGFtb2RlbC9yb3V0ZS5weQ==) | `82.31% <57.14%> (-9.77%)` | :arrow_down: |