search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
214 stars 52 forks source link

urllib3 dependency version should be updated to use "allowed_methods" parameter #895

Closed SivaKesava1 closed 1 year ago

SivaKesava1 commented 1 year ago

Hello Team,

There was a recent commit to use the latest urllib3 Retry interface. In the dependency doc, it still refers to the older version 1.25.8, and that version seems to not have the argument 'allowed_methods'.

I installed pybatfish today using python3 -m pip install --upgrade pybatfish and when I ran, I got the error:

File \"/usr/local/lib/python3.8/dist-packages/pybatfish/client/restv2helper.py\", line 60, in <module>\n   
max_retries=Retry(\nTypeError: __init__() got an unexpected keyword argument 'allowed_methods'\n",

Thanks, Siva

dhalperi commented 1 year ago

1/ What took you to the linked configuration for Sphinx environments? That's not meant to be user facing. 2/ Thanks; you should be able to just run pip install --upgrade urllib3>=1.26.0

dhalperi commented 1 year ago

Edited to fix version pasted in

SivaKesava1 commented 1 year ago

I searched for urllib3 in the repo and came across that and then checked out the urllib3 source code.

dhalperi commented 1 year ago

Ack; that environment yaml file has nothing to do with the versions that users see. A total red herring :)