search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
208 stars 51 forks source link

pybatfish: mypy improvements #898

Closed dhalperi closed 9 months ago

batfish-bot commented 9 months ago

This change is Reviewable

codecov[bot] commented 9 months ago

Codecov Report

Merging #898 (13c3f23) into master (8accf73) will decrease coverage by 12.10%. The diff coverage is 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #898 +/- ## =========================================== - Coverage 85.54% 73.44% -12.10% =========================================== Files 30 30 Lines 3977 3977 Branches 664 664 =========================================== - Hits 3402 2921 -481 - Misses 430 925 +495 + Partials 145 131 -14 ``` | [Files](https://app.codecov.io/gh/batfish/pybatfish/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/client/session.py](https://app.codecov.io/gh/batfish/pybatfish/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9zZXNzaW9uLnB5) | `46.85% <0.00%> (-28.91%)` | :arrow_down: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/batfish/pybatfish/pull/898/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish)