search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
208 stars 51 forks source link

TestRoutePolicies: Add optional parameter for BGP session properties #905

Closed millstein closed 4 months ago

millstein commented 4 months ago

The pybatfish counterpart to Batfish PR 8987

batfish-bot commented 4 months ago

This change is Reviewable

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.60%. Comparing base (93da6c2) to head (25fb8aa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #905 +/- ## ========================================== + Coverage 85.54% 85.60% +0.06% ========================================== Files 30 30 Lines 3977 3995 +18 Branches 817 819 +2 ========================================== + Hits 3402 3420 +18 Misses 430 430 Partials 145 145 ``` | [Files](https://app.codecov.io/gh/batfish/pybatfish/pull/905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/datamodel/primitives.py](https://app.codecov.io/gh/batfish/pybatfish/pull/905?src=pr&el=tree&filepath=pybatfish%2Fdatamodel%2Fprimitives.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2RhdGFtb2RlbC9wcmltaXRpdmVzLnB5) | `95.48% <100.00%> (+0.02%)` | :arrow_up: | | [pybatfish/datamodel/route.py](https://app.codecov.io/gh/batfish/pybatfish/pull/905?src=pr&el=tree&filepath=pybatfish%2Fdatamodel%2Froute.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2RhdGFtb2RlbC9yb3V0ZS5weQ==) | `92.69% <100.00%> (+0.61%)` | :arrow_up: | | [pybatfish/question/question.py](https://app.codecov.io/gh/batfish/pybatfish/pull/905?src=pr&el=tree&filepath=pybatfish%2Fquestion%2Fquestion.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL3F1ZXN0aW9uL3F1ZXN0aW9uLnB5) | `82.66% <ø> (ø)` | |