search

batfish / pybatfish

Python client for Batfish: https://github.com/batfish/batfish
Apache License 2.0
208 stars 51 forks source link

delete unsupported v1 support #910

Closed dhalperi closed 2 months ago

dhalperi commented 2 months ago

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

batfish-bot commented 2 months ago

This change is Reviewable

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.00%. Comparing base (3e97f77) to head (902ab7b). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #910 +/- ## ========================================== + Coverage 85.73% 87.00% +1.26% ========================================== Files 25 24 -1 Lines 3758 3654 -104 Branches 795 770 -25 ========================================== - Hits 3222 3179 -43 + Misses 390 339 -51 + Partials 146 136 -10 ``` | [Files](https://app.codecov.io/gh/batfish/pybatfish/pull/910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish) | Coverage Δ | | |---|---|---| | [pybatfish/client/internal.py](https://app.codecov.io/gh/batfish/pybatfish/pull/910?src=pr&el=tree&filepath=pybatfish%2Fclient%2Finternal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9pbnRlcm5hbC5weQ==) | `78.94% <100.00%> (+9.38%)` | :arrow_up: | | [pybatfish/client/session.py](https://app.codecov.io/gh/batfish/pybatfish/pull/910?src=pr&el=tree&filepath=pybatfish%2Fclient%2Fsession.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC9zZXNzaW9uLnB5) | `81.10% <100.00%> (+3.52%)` | :arrow_up: | | [pybatfish/client/workhelper.py](https://app.codecov.io/gh/batfish/pybatfish/pull/910?src=pr&el=tree&filepath=pybatfish%2Fclient%2Fworkhelper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=batfish#diff-cHliYXRmaXNoL2NsaWVudC93b3JraGVscGVyLnB5) | `69.18% <100.00%> (+3.80%)` | :arrow_up: |