theming: mute tag for videos stop working

[pajarorrojo]

Hi @fabricecaruso mute audio function for videos stop working in latest beta, im talking about:

<video name ="custom-video">
   <audio>false</audio>
</video>

tested on rpi4 and x86_64 latest beta with same issue

Thanks!

[Tovarichtch]

I confirm the bug. It has been reported in #beta various times. It's all across platforms (x86_64 here).

[fabricecaruso]

I don't reproduce. It's working as expected here. You need to provide more informations ( theme ? settings ? )

Please post your es_settings.cfg file ( telling me what should be configured in it )

[Tovarichtch]

x86_64 on my part.

Checked for es-carbon, RCBX, Artflix. All doing the same. Sound settings, "enable preview videos sound" disabled. Something interesting tho : long time after going into screensaver mode (few hours) and going out of it using my controller, the video preview sounds stopped. I rebooted and it came back once again. This was not present in december betas.

Here's the content of my es_settings.cfg file.

<?xml version="1.0"?>
<config>
    <bool name="EnableSounds" value="true" />
    <bool name="ScrapeFanart" value="true" />
    <bool name="ScrapeVideos" value="true" />
    <bool name="VideoAudio" value="false" />
    <bool name="mrboom.ungroup" value="true" />
    <bool name="odcommander.ungroup" value="true" />
    <bool name="prboom.ungroup" value="true" />
    <bool name="sdlpop.ungroup" value="true" />
    <bool name="superbroswar.ungroup" value="true" />
    <int name="ScreenSaverTime" value="60000" />
    <int name="audio.display_titles_time" value="4" />
    <string name="CollectionSystemsAuto" value="lightgun" />
    <string name="HiddenSystems" value="mrboom;prboom;sdlpop;superbroswar;odcommander;pygame" />
    <string name="INPUT P6NAME" value="DEFAULT" />
    <string name="INPUT P7NAME" value="DEFAULT" />
    <string name="INPUT P8NAME" value="DEFAULT" />
    <string name="LastSystem" value="daphne" />
    <string name="Scraper" value="ArcadeDB" />
    <string name="ScrapperLogoSrc" value="marquee" />
    <string name="ScreenScraperPass" value="bibubi" />
    <string name="ScreenScraperUser" value="rafeeq" />
    <string name="ShowFlags" value="auto" />
    <string name="ThemeRegionName" value="us" />
    <string name="ThemeSet" value="es-theme-RCBX" />
    <string name="lightgun.ShowFlags" value="auto" />
    <string name="subset.controller" value="gamepad" />
    <string name="subset.helpIcons" value="xboxOneIcons" />
    <string name="subset.music" value="allowGeneral" />
    <string name="subset.paintSystem" value="yes" />
    <string name="subset.paintSystemSaturation" value="50%" />
</config>

[pajarorrojo]

In my case I use some background videos in my theme (playstation-x) and the audio property true/false has stopped working, it is just like the code extract that I pasted above.

[pajarorrojo]

an example, but i use in more scenarios:

https://github.com/pajarorrojo/es-theme-PlayStation-X/blob/d0004bafe0ed3f67b8b0d7b16da9f5abe532b24a/_theme_options/systemvideo/enable-video-bg.xml#L17

[fabricecaruso]

Does it concerns only videos ? I mean, navigation sounds & background music settings are applying correctly ?

Maybe it's not related to EmulationStation, but to the last VLC version ( ES calls "libvlc_audio_set_mute(mMediaPlayer, 1)" to mute video audio - looks like it has no effect )

[Tovarichtch]

Navigation sound settings is not working. It remains muted, even if enabled. Background music (frontend music?) can be enabled/disabled correctly, but I'm using my own music in /music/ folder.

[pajarorrojo]

yes only concerns to the video tag in my case, to the audio property.

[pajarorrojo]

Navigation sound and background work fine for me and apply changes after reboot, not instant but I think it worked like this before

[pajarorrojo]

edit: navigation sound apply changes after reboot, not intant, background sound works like expect

[pajarorrojo]

For your interest, the main option: SOUND SETTINGS -> ENABLE VIDEO PREVIEW AUDIO works and mute unmute all videos (after rebooting)

[fabricecaruso]

So what's the problem ?

[pajarorrojo]

Just what I indicated in the first message, the property does not work in the themes coding for videos.

In my theme I use background videos that if they have the audio activated can be very annoying, for this I have a series of subsets in the configuration of my theme that activate or deactivate the audio of the background videos.

We already talked some time ago about muting custom videos and how to do it

https://github.com/batocera-linux/batocera-emulationstation/issues/871#issuecomment-841742945

now it doesn't work

[pajarorrojo]

install playstation-x theme from the UI and you can see for yourself. In the theme options you can configure if you want to activate or deactivate the audio of the background videos (system videos, ads), in version 35 it works correctly, not in the last beta

[pajarorrojo]

and now that we have the thread open, IMHO the main option "ENABLE VIDEO PREVIEW AUDIO" should only mute or unmute the game videosnap (name="md_video") as indicated, and not all the videos shown on the frontend...

[fabricecaruso]

I don't reproduce neither on Ubuntu or Windows by compiling the latest source code.

Accordingly, and since the code has not changed for several months on this part, it's probably not directly related to EmulationStation -> It should be the same with 35 as the source code is the same.

I presume batocera.linux team bumped libvlc to a recent version. And libvlc_audio_set_mute is probably not always working anymore correctly.

[pajarorrojo]

Well, what a nuisance. I think many users who use my theme aren't going to be happy about this. Maybe @nadenislamarre can clarify or help us solve this issue. Thanks Fabrice.

[pajarorrojo]

forward: https://github.com/batocera-linux/batocera.linux/issues/7891