batocera-linux / batocera-emulationstation

MIT License
322 stars 248 forks source link

Enhancement: ES theming: control sound of videos with an xml tag #871

Closed pajarorrojo closed 3 years ago

pajarorrojo commented 3 years ago

I think it would be very positive for theme developing the possibility to control the volume of videos with an xml tag or simply , this would be wonderful for theme design purposes like background custom videos where sound may not be so necessary.

Something like?:

<mute>boolean true/false</mute> 
<volume>integer value 0 to 100</volume> 

Just ideas! ;) Thanks again for the hard work!!

fabricecaruso commented 3 years ago

mute function already exists using <audio>false</audio> Volume : no interest.

pajarorrojo commented 3 years ago

mute function already exists using false

You mean the general option to activate or deactivate volume?

fabricecaruso commented 3 years ago

no. in themes

pajarorrojo commented 3 years ago

https://wiki.batocera.org/write_themes_for_emulationstation

i have checked the wiki again and i dont see it.

for example:

<video name ="custom-video" extra = "true">
   <audio> false </audio>
</video>

You mean that would be the correct way?

I did not know it, I am away from home, but as soon as I arrive I try it immediately, you have made my day :)

pajarorrojo commented 3 years ago

mute function already exists using <audio>false</audio>

Im so happy now!!! Thanks Fabrice!!