Wrong scaler value in Scummvm

[JuanMiguelBG]

Batocera build version

v38

Your architecture

Steam Deck

Your Graphic Processor Unit (GPU)

None

Graphical brand

None

Issue description

In the file es_features.yaml, there is a wrong value for the property scumm_scaler_mode.

The value for TV2x CRT Television Filter should be tv instead of tv2x.

The value tv2x is applied to the legacy property gfx_mode.

Expected result

No response

Reproduction steps

Change the scummvm scaler value to TV2x CRT Television Filter and launch a game.

or

Change the scummvm scaler value to Normal. Launch a game. Change the scummvm scaler value to TV2x CRT Television Filter. Launch a game.

Logs and data

You can check on the Scummvm source code:

base\plugins.cpp - line 1081 - tv2x value definition on the s_legacyGraphicsModes variable declaration base\plugins.cpp - line 1084 - isOldGraphicsSetting() function declaration that uses s_legacyGraphicsModes variable base/main.cpp - line 553- isOldGraphicsSetting() function call based on the gfx_mode definition

The Scummvm wiki is wrong.

base/commandLine.cpp - line 112 - scaler CLI parameter comentary Scummvm command line

[JuanMiguelBG]

Scummvm ticket to fix the wrong value.

[dmanlfc]

thanks @JuanMiguelBG very detailed bug report. fixed.

[JuanMiguelBG]

Thank you for your (Batocera Team) great work.