search

batocera-linux / batocera.linux

batocera.linux
https://batocera.org
Other
1.92k stars 494 forks source link

Please package my chromebook ucm properly #11006

Closed WeirdTreeThing closed 5 months ago

WeirdTreeThing commented 7 months ago

Batocera build version

n/a

Your architecture

n/a

Your Graphic Processor Unit (GPU)

None

Graphical brand

None

Issue description

Your current chromebook-ucm-conf package breaks support for many devices due to the way you package it. What you should do is download the latest release of alsa-ucm-conf-cros and copy everything from ucm2/ to /usr/share/alsa/ucm2/.

This will only really fix SOF devices though. AVS devices won't work without kernel patches and other topology files.

Expected result

No response

Reproduction steps

n/a

Logs and data

No response

dmanlfc commented 7 months ago

@WeirdTreeThing thanks for the note. I noticed your other source doesn't have many chromebook ucm2 topologies however. Or am I reading that wrong?

When you say it's breaks many devices, which ones? I added this package to fix many Chromebooks issues which we were able to tick off thanks to your repo & associated ucm2 topologies...

WeirdTreeThing commented 7 months ago

I noticed your other source doesn't have many chromebook ucm2 topologies however. Or am I reading that wrong?

All the chromebook stuff is on the standalone branch. The other branches are for upstreaming.

When you say it's breaks many devices, which ones?

The way you package it currently will copy every sof-rt5682 folder over itself, which will overwrite them and cause only the last one to actually be there. Since sof-rt5682 applies to 4 different generations of chromebooks, this will probably break 3 of the 4. However, I have now done ucm magic to merge all sof-rt5682 configs into a single one that applies to all chromebooks. You don't technically need the standalone repo, it just makes packaging easier. Let me know if you want to work out avs problems too.

And if you were wondering how I handled sof-rt5682 before, the script would figure out which chromebook generation you had, and copy of the correct config. Now the ucm will check the generation itself (ucm truly is magic) and kinda fills out the actual config like a template based on the generation.

dmanlfc commented 7 months ago

@WeirdTreeThing thanks. We are in a change freeze currently for the v39 release. I will switch to the standalone branch & repo you recommended as soon as we can.