dolphinSYSCONF.py fails to set aspect ratio in emulated Wii NAND

[Hew-ux]

Issue: The internal aspect ratio for Wii games in Dolphin is not set correctly. The game will just use whatever was set last in dolphin-emu-config.

Expected result: When selecting 4:3, to use the game's 4:3 mode. When selecting 16:9, to use the game's 16:9 mode.

Reproduction steps: 1. Play a Wii game in Dolphin with 16:9 aspect ratio set. Everything is fine.

2. Set the aspect ratio to 4:3.
3. Play a Wii game again. The physical aspect ratio is now 16:9 squished to 4:3.

Logs: The logs would not be able to provide any meaningful information as the issue is with the generator itself, but here it is in case anyone is curious:

es_launch_stdout.log

The SYSCONF file when launching a game that supports both 16:9 and 4:3 in 16:9 mode (regular Batocera ES launch): SYSCONF with 16 9 wii ratio.txt

The SYSCONF file when launching a game that supports both 16:9 and 4:3 in 4:3 mode (launched from dolphin-emu): SYSCONF with 4 3 ratio when launched from dolphin-emu.txt

The SYSCONF file when launching a game that supports both 16:9 and 4:3 in 4:3 mode (regular Batocera ES launch): SYSCONF with 4 3 ratio.txt

Workarounds: This can be set manually in dolphin-emu-config.

The reason this is an issue is that there seems like there is code in dolphinSYSCONF.py to automatically detected and use the correct settings, then save them to the emulated Wii's NAND (located at saves/dolphin-emu/Wii/shared2/sys/SYSCONF), but it fails to even touch the file. Only setting it by dolphin-emu-config works, and the setting made there is not overwritten by dolphinSYSCONF.py.

Screenshot of when set to 16:9 in game that supports both 16:9 and 4:3:

Screenshot of when set to 4:3 in a game that supports both 16:9 and 4:3 (notice how squished the illustration of the hand is):

Screenshot of when set to 4:3 in a game that supports both 16:9 and 4:3 after setting the appropriate aspect ratio setting in dolphin-emu (notice that the hand looks fine now):

Here is the respective setting in Dolphin's GUI:

I want to emphasis that this is unrelated to the setting set here:

[Hew-ux]

What has been attempted to fix it so far:

• Editing line 83 and 85 to f = open("/userdata/saves/dolphin-emu/Wii/shared2/sys/SYSCONF", "rb+"), f = open("/userdata/saves/dolphin-emu/Wii/shared2/sys/SYSCONF", "r+b") and f = open("/userdata/saves/dolphin-emu/Wii/shared2/sys/SYSCONF", "wb+"). It seems to be accessing and reading the file just fine, it's just not writing to it correctly or Dolphin is overwriting the file after the fact.

[dmanlfc]

fixed: https://github.com/batocera-linux/batocera.linux/pull/5123

[dmanlfc]

You can close this one

[Hew-ux]

The PR has not been merged yet, but if you say so.