batocera-linux / batocera.linux

batocera.linux
https://batocera.org
Other
1.96k stars 512 forks source link

Scraping with ScreenScraper fails for The Secret of Monkey Island [scummvm] #5351

Closed wizzomafizzo closed 8 months ago

wizzomafizzo commented 2 years ago

Scraping through ScreenScraper causes The Secret of Monkey Island's existing gamelist data to be wiped and the title replaced with ZZZ(notgame). Tried 3 different versions of the game: CD DOS VGA. Floppy DOS VGA, Floppy DOS EGA. This issue does not occur with any other (~20) ScummVM games in collection, they all work as expected.

Followed instructions as per wiki:

  1. Created top level folder called "The Secret of Monkey Island (CD DOS VGA)" containing game files
  2. Created empty file called monkey.scummvm
  3. Game shows as expected in system section without metadata and will run correctly

Running a scrape at this point will wipe the metadata and replace the name with ZZZ(notgame):Monkey

I was able to work around the issue by:

  1. Creating the game folder with .scummvm appended to the name
  2. Run the scrape (which now works as expected)
  3. Remove the .scummvm on the end of the folder name
  4. Create the monkey.scummvm file in the directory
  5. Edit the entry in the gamelist.xml file and change the path to point to the monkey.scummvm file
  6. Rebuild game list

After this, I am able to run the game, it has populated metadata, and the metadata is not wiped during any following scrapes. I am not sure if this has actually fixed the issue (there is a new md5 setting in the entry) or if it's simply being ignored by the scraper now because it no longer has any missing data.

wizzomafizzo commented 2 years ago

This was on v32 but have also confirmed it happening on v33 beta 2022/01/06. Once more media was required, issue happened again after above steps. MD5 setting did not make a difference (tried the empty file hash and one straight from screenscraper)

maddawik commented 2 years ago

This was an issue I ran into too. In case it helps anyone else in the future, I worked around it by using Skraper on my Windows Desktop PC and then dragging/dropping the files manually - then editing the gamelist.xml to point to those new files. It's a little cumbersome but it works. Note: You need to edit the default media that Skraper pulls down so that you get the files you want, manual, 3D/2D box art, etc.