batocera-linux / batocera.linux

batocera.linux
https://batocera.org
Other
2.05k stars 529 forks source link

DuckStation settings not being fully used in ES (especially for True Color Rendering & disabling dithering options) #6820

Closed RaptorZX4 closed 2 years ago

RaptorZX4 commented 2 years ago

At least some of the DuckStation settings (like True Color Rendering, and then being able to DISABLE dithering) when booted up from Linux outside ES, are not saved or are not being used, if you boot a PS1 game using DuckStation in ES.

Here is a conversation i had on Discord to report it:

TheRaptor when i use DuckStation at 1280x960 resolution for PS1 games, most of the time i see that big horrible dithering on the game screen! Is that normal for PS1 games cos normally it would be a lot less visible in the normal resolution? or it's an emulation thing? i tried Motorhead and Ridge Racer Type 4, like that.

Tovarichtch 100% emulation thing. Try with different graphic API (if supported)

Tovarichtch I believe there's an option to scale the dithering itself So it's less apparent

TheRaptor the dithering thing isn't in Batocera itself, you have to press F1 in main menu to then go in Duckstation

Tovarichtch It should be enable by default, maybe that's why it's not there in ES

TheRaptor @Tovarichtch i don't think it's an emulation thing, i just tried Ridge Racer Type 4 with PCSX Rearmed and i still see dithering

Tovarichtch Maybe it's a game thing ?

TheRaptor yeah i think the PS1 is doing dithering on purpose "when needed" or something

Tovarichtch I'm sure it's removable (if you really want to)

TheRaptor it's really annoying on HD screens though SwanStation seem to get rid of that dithering, not completely, but a lot less noticeable but so far only DuckStation have a config executable outside of Batocera i see there is a topic about Libretro: PCSX-Rearmed, which is the recommended PS1 emulator for Batocera. the topic is from 2017, which is many years ago, and it seem like they added the option, so...there IS supposed to be an option to disable the dithering, but i can't see it in Batocera.

Atari this is the default setting i believe, you can switch it to using a higher quality ditherer however it's less accurate.

Atari in no way is pcsx-rearmed recommended lmao

TheRaptor When i boot up Ridge Racer Type 4 directly from the Duckstation emulator outside of Batocera, WHILE having true color option enabled, i don't see dithering. BUT if i play the game in the Batocera emulator, i see dithering. I think Batocera doesn't take in account some of the DuckStation settings. the "True Color Rendering" setting in DuckStation allow you to turn off the Dithering option afterward. But if you boot it up in Batocera, it doesn't take these saved options in.

Atari configure duckstation (btw standalone may be dropped at some point as it was abandoned) launch it to confirm and then launch it via ES. Then launch the standalone without configuration, does it have the configuration you set or not after this?

TheRaptor i configured both, but in ES (so it's how it's called?), it doesn't take all the settings from the standalone DuckStation i guess this is because there's no enabled True Color AND disabled dithering options in ES directly, so i guess ES, by default, doesn't touch those. like both have separate settings configuration files. why? because i can't seem to make my PS4 controller work in DuckStation (even though it's plugged in USB), but work just fine in ES

Atari you're right, so it shouldn't be touching the true colour setting it could be that configgen is leaving the file in a corrupt state when exiting or a dev has hard-coded their own preference... I'll investigate it later, night want to make an issue report.

Tovarichtch Now that's very very sneaky of them !

nadenislamarre commented 2 years ago

issues must be synthetic, focused on a problem.

RaptorZX4 commented 2 years ago

i have no idea what kind of problem it is, if it's an emulator problem or ES not taking all of the emulator settings in account when booting up a game.

nadenislamarre commented 2 years ago

the pb is not that you dont know the solution. a minimum of quality is wanted on tickets. discord copy and paste of long conversation cannot be used to initialize a ticket.

RaptorZX4 commented 2 years ago

ok so the problem will be completely ignored because the ticket wasn't filled as the Batocera team would like it to be? Even though you understand what the problem is?

Tovarichtch commented 2 years ago

I agree that the issue posted is pretty lazy with no valuable information. But the problem is real : ES adv. opts. for DuckStation are limited. True Color Rendering and Dithering are not there. Changing those options in DuckStation manually before launching a rom are not saved, so the only way is to do it while playing a rom and must do it again each time we quit the emulator. Those options are needed if playing beyond native resolution to avoid noticeable distortion of pixels and colors.