Closed sgtsquiggs closed 6 years ago
This repo can continue to host the "times" directory for running standardized tests against, we can then have it as a submodule in the language specific repos.
There are now 3 separate libraries for the language specific ports of Adhan
https://github.com/batoulapps/adhan-swift https://github.com/batoulapps/adhan-java https://github.com/batoulapps/adhan-js
This main repo will be kept open for issues concerning the equations themselves and for discussing calculation methods. It will also host the test data for various cities, each language specific repo has a copy of this main repo as a subtree in order to access the shared test data. Once the package managers have been updated to point to the new location we will remove the language specific implementations from this repo.
I propose we move all Adhan versions into their own repos and then deprecate this one.
We would have
batoulapps/adhan-swift
,batoulapps/adhan-java
,batoulapps/adhan-js
.Leave this repo as-is and deprecate it so that we don't break any existing usage of
batoulapps/Adhan
.Benefits:
Downsides:
Also currently using the cocoapod downloads all the java/javascript stuff and that ain't right