search

batoulapps / Adhan

High precision prayer time library
MIT License
313 stars 64 forks source link

Request for JAKIM, Malaysia prayer time #78

Closed adiman-dev closed 6 years ago

adiman-dev commented 6 years ago

Assalamualaikum brothers,

Awesome library and may Allah reward all of you with your efforts.

I would like to request for a new method to be added which is JAKIM, Malaysia. Here are some links that may be useful for reference. Thank you

Calculation reference: http://www.e-solat.gov.my/web/index1.php?id=56&type=A

Timetable for Kuala Lumpur for reference: http://www.e-solat.gov.my/web/waktusolat.php?negeri=Putrajaya&zone=SGR04&jenis=mont&state=Putrajaya&submit=Cari

z3bi commented 6 years ago

Unfortunately the calculation reference is in Malaysian, and google translate doesn't help very much as a lot of the information is contained within images.

Looking at the timetable though, it seems that the newly implemented Singapore method generates times very similar to that timetable. Please try using the Singapore method and let me know if there are any significant variations (5 minutes or greater).

adiman-dev commented 6 years ago

Too bad that the page didn't have an english version :(

Okay i will try Singapore method and compare with the timetable from JAKIM and will update the time variations.

adiman-dev commented 6 years ago

Hi @z3bi

Kindly refer the variance i get. The most is for fajr with 8~9 minutes difference.

Maghrib and isha also having a high variant of 2~3 throughout the month

Output in GMT+8

image

z3bi commented 6 years ago

@litium actually you need to compare to their "Subuh" time, not the "Imsak" time. It appears that the imsak time is simply a fixed 10 minutes before fajr to be used for knowing when to stop eating suhoor when fasting.

adiman-dev commented 6 years ago

yes. silly mistake. i got the wrong column when comparing the data. the difference is so far okay with manual adjustments.

ghost commented 6 years ago

@litium @z3bi

Assalamu Alaikum.

I would like to add more information for the JAKIM method. JAKIM method uses Fajr and Isha Angle as Singapore method (Fajr Angle: 20.0 degree, Isha Angle: 18.0 degree). I have tested this for different locations in Malaysia.

@litium You can use the Singapore Method for now. I will request for adding JAKIM method with the required information.

adiman-dev commented 6 years ago

Wa'alaikumusalam

@ahamedsaifudeen thank you. Will use Singapore method with manual adjustments for now

ghost commented 6 years ago

@litium

Please let me know once you have the adjustments data for Malaysia. I am currently using singapore method with no adjustments.

FYI, I have requested for adding JAKIM method in Adhan.