search

batoulapps / Adhan

High precision prayer time library
MIT License
329 stars 63 forks source link

Please add prayer times method for Malaysia #80

Closed ghost closed 7 years ago

ghost commented 7 years ago

JAKIM - Jabatan Kemajuan Islam (Malaysia) prayer calculation method is used in Malaysia. Please help to add this prayer calculation method in Adhan.

Fajr Angle: 20.0 degree Isha Angle: 18.0 degree

Official Prayer Times data for Malaysia is available here - http://www.e-solat.gov.my/web/waktusolat.php?negeri=Putrajaya&zone=SGR04&jenis=mont&state=Putrajaya&submit=Search

You can use this data for adding tests.

adiman-dev commented 7 years ago

The calculations: http://www.e-solat.gov.my/web/index1.php?id=55&type=A

From the above, i can only understand that Dhuhr is defined 1 minute 4 seconds after the sun passed the zenith.

Other than that, the jargon and formula is too complicated for me to understand

Anybody can translate this would be appreciated

z3bi commented 7 years ago

Issue #78 already made this request and it was closed due to the ability to use the Singapore method instead. I'm not in favor of adding redundant methods that have the exact same values. In your app you are free to present a JAKIM method to the user, but then internally select the Singapore method in the library. If we are able to translate the official calculation description then that would be different enough to implement as its own method.

ghost commented 7 years ago

I agree with you @z3bi. Same method is used in Singapore, Malaysia, Brunei and Indonesia (but with different names). Probably, we should rename the SingaporeMethod in code to something more meaningful :)

amierfirdaus commented 5 years ago

@ahamedsaifudeen you have prayer times in c++?

ghost commented 5 years ago

@amierfirdaus

I don't think Adhan is available for C++. @z3bi can confirm.

You can check this - http://praytimes.org/code/ (This library may not be up to date)

z3bi commented 5 years ago

@amierfirdaus @ahamedsaifudeen there is not a C++ version of Adhan, but someone did port it to C. You should be able to compile it inside of your C++ project. https://github.com/radcheb/Adhan/tree/master/C/adhan