batoulapps / Adhan

High precision prayer time library
MIT License
329 stars 63 forks source link

Reorganizing code #86

Closed insha closed 6 years ago

insha commented 6 years ago

This is as per the recommendation from issue#60.

z3bi commented 6 years ago

Thank you for doing this. I have one small suggestion before merging this in. Instead of the "enums" directory, perhaps call it "Configuration" as it contains non-enums such Coordinates. And then you can also include ShadowLength and CalculationParameters under "Configuration".

insha commented 6 years ago

Sure thing.

One other thing, what would you like in the header comments for each of the new files? If you have a snippet I will be more than happy to add it to the header comment.

z3bi commented 6 years ago

Good idea, we should probably include the following below what is already there:

//  Permission is hereby granted, free of charge, to any person obtaining a copy
//  of this software and associated documentation files (the "Software"), to deal
//  in the Software without restriction, including without limitation the rights
//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
//  copies of the Software, and to permit persons to whom the Software is
//  furnished to do so, subject to the following conditions:
//
//  The above copyright notice and this permission notice shall be included in
//  all copies or substantial portions of the Software.
//
//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
//  THE SOFTWARE.
//
z3bi commented 6 years ago

If you can move ShadowLength.swift, PrayerAdjustment.swift, TimeComponents.swift, and CalculationParameters.swift into the "Configuration" directory then I think this PR will be ready for merging.