search

batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript
MIT License
376 stars 86 forks source link

Rewrite in typescript #101

Closed sgtsquiggs closed 2 years ago

sgtsquiggs commented 2 years ago

This is a placeholder PR that shouldn't be merged until after #98. All ts files come from #93.

Prefer this PR be redone by @abumalick for proper attribution!

codecov[bot] commented 2 years ago

Codecov Report

Merging #101 (4ee4f08) into develop (e5c07b4) will decrease coverage by 0.36%. The diff coverage is 98.11%.

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    98.80%   98.44%   -0.37%     
===========================================
  Files           19       19              
  Lines          587      577      -10     
  Branches       127      114      -13     
===========================================
- Hits           580      568      -12     
- Misses           6        9       +3     
+ Partials         1        0       -1
Impacted Files Coverage Δ
src/Adhan.ts 100.00% <ø> (ø)
src/Prayer.ts 100.00% <ø> (ø)
src/Rounding.ts 100.00% <ø> (ø)
src/Shafaq.ts 100.00% <ø> (ø)
src/CalculationParameters.ts 91.66% <91.66%> (ø)
src/Astronomical.ts 99.11% <100.00%> (ø)
src/CalculationMethod.ts 100.00% <100.00%> (ø)
src/Coordinates.ts 100.00% <100.00%> (ø)
src/DateUtils.ts 100.00% <100.00%> (ø)
src/HighLatitudeRule.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c15ba6e...4ee4f08. Read the comment docs.

sgtsquiggs commented 2 years ago

Fixes #100

abumalick commented 2 years ago

Thank you @sgtsquiggs , I will try to finish my PR today inchallah. I can use your changes to the rollup config from here right?

sgtsquiggs commented 2 years ago

Thank you @sgtsquiggs , I will try to finish my PR today inchallah. I can use your changes to the rollup config from here right?

Yeah please mirror the configurations here - babel, eslint, tsconfig, rollup, and package.json

abumalick commented 2 years ago

Done, I did small changes to eslint configuration and package.json, please check it on https://github.com/batoulapps/adhan-js/pull/93 when you have time 👍🏻