Misalignment between arguments order in types file and implementation file

batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript

MIT License

376 stars 86 forks source link

Misalignment between arguments order in types file and implementation file #69

Closed korbav closed 3 years ago

korbav commented 3 years ago

Salam Alaykum, I noticed a problem with the order of the arguments in the types file, I take profit from the fact we're releasing another version soon to add the Rounding: Rounding export to expose this little issue.

Adhan.d.ts

constructor(fajrAngle: number, ishaAngle: number, methodName?: string, ishaInterval?: number, maghribAngle?: number)

Adhan.js

constructor(methodName, fajrAngle, ishaAngle, ishaInterval, maghribAngle)

This leads to invalid suggestions being shown in IDEs :

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 4.2.1 :tada:

The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: