batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript

MIT License

376 stars 86 forks source link

v4.3.0 #81

Closed z3bi closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (32258cb) into master (7b4937f) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   99.26%   99.28%   +0.01%     
==========================================
  Files          18       19       +1     
  Lines         546      558      +12     
  Branches       96       98       +2     
==========================================
+ Hits          542      554      +12     
  Misses          4        4

Impacted Files	Coverage Δ
src/Astronomical.js	`100.00% <100.00%> (ø)`
src/CalculationParameters.js	`100.00% <100.00%> (ø)`
src/PrayerTimes.js	`100.00% <100.00%> (ø)`
src/Shafaq.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b4937f...32258cb. Read the comment docs.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

korbav commented 2 years ago

@z3bi I'm sorry I just noticed we're not exporting the Shafaq object :

const adhan = {
  Prayer: src_Prayer,
  Madhab: Madhab,
  HighLatitudeRule: src_HighLatitudeRule,
  Coordinates: Coordinates,
  CalculationParameters: CalculationParameters_CalculationParameters,
  CalculationMethod: src_CalculationMethod,
  PrayerTimes: PrayerTimes_PrayerTimes,
  SunnahTimes: SunnahTimes_SunnahTimes,
  Qibla: qibla,
  PolarCircleResolution: PolarCircleResolution,
  Rounding: Rounding
};

I think what we should do is the following:

const adhan = {
  Prayer: src_Prayer,
  Madhab: Madhab,
  HighLatitudeRule: src_HighLatitudeRule,
  Coordinates: Coordinates,
  CalculationParameters: CalculationParameters_CalculationParameters,
  CalculationMethod: src_CalculationMethod,
  PrayerTimes: PrayerTimes_PrayerTimes,
  SunnahTimes: SunnahTimes_SunnahTimes,
  Qibla: qibla,
  PolarCircleResolution: PolarCircleResolution,
  Rounding: Rounding,
  Shafaq: Shafaq
};

z3bi commented 2 years ago

Yup, I definitely forgot to do that. Thank you.

z3bi commented 2 years ago

@korbav ok 4.3.1 should now be fixed

korbav commented 2 years ago

@korbav ok 4.3.1 should now be fixed

It works great! Thank you