batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript
MIT License
379 stars 86 forks source link

fix(prayer times): fix polar circle prayer times #88

Closed z3bi closed 2 years ago

z3bi commented 2 years ago

We are no longer resetting the date of the prayer time date property when AqrabYaum is used. This fixes an issue with night portion calculations and keeps the prayer times on the correct calendar day so that any countdown or ordering logic would still work correctly.

codecov[bot] commented 2 years ago

Codecov Report

Merging #88 (0041629) into develop (22aedeb) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    99.28%   99.27%   -0.01%     
===========================================
  Files           19       19              
  Lines          558      555       -3     
  Branches        98       98              
===========================================
- Hits           554      551       -3     
  Misses           4        4              
Impacted Files Coverage Δ
src/PrayerTimes.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64ffe93...0041629. Read the comment docs.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 4.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: