search

batoulapps / adhan-js

High precision Islamic prayer time library for JavaScript
MIT License
376 stars 86 forks source link

Modernize bundling #99

Closed sgtsquiggs closed 2 years ago

sgtsquiggs commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #99 (ea55695) into develop (ee6fc0c) will increase coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
+ Coverage    98.78%   98.80%   +0.02%     
===========================================
  Files           19       19              
  Lines          576      587      +11     
  Branches       116      127      +11     
===========================================
+ Hits           569      580      +11     
  Misses           6        6              
  Partials         1        1
Impacted Files Coverage Δ
src/PrayerTimes.js 100.00% <0.00%> (ø)
src/HighLatitudeRule.js 100.00% <0.00%> (ø)
src/Astronomical.js 99.12% <0.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8246e67...ea55695. Read the comment docs.

z3bi commented 2 years ago

Awesome! But let's keep the tests in the test directory. We probably also want to update the example.html to pull in the new correct file.

Also I'm wondering if we should commit the lib directory or generate it as a build artifact?

z3bi commented 2 years ago

Looking at other libraries like https://github.com/chartjs/Chart.js they don't commit their dist directory. This will also allow us to remove the check in the build script.

sgtsquiggs commented 2 years ago

Awesome! But let's keep the tests in the test directory.

I’ve always kept them together but also my projects are very large. Keeping tests next to the code being tested is easier to work with when your repo is large. Fine to separate here.

We probably also want to update the example.html to pull in the new correct file.

If we aren’t committing the end result (lib) then example won’t have anything to reference. Could create an example with its own package.json that would achieve the same end result.

Also I'm wondering if we should commit the lib directory or generate it as a build artifact?

We don’t need to commit it - it’ll be in the npm package and that’s good enough.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: