search

batoulapps / adhan-kotlin

High precision Islamic prayer time library for Java
MIT License
148 stars 46 forks source link

DateComponents: Support LocalDate #32

Closed hsravat-4590 closed 2 years ago

hsravat-4590 commented 3 years ago

An app that I was working on used LocalDate for most date operations. Converting from LocalDate to Date to use this library caused the times to come out wrong. This PR aims to allow you to construct a DateComponents object using LocalDate

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (1c992d0) into master (eefc4ed) will decrease coverage by 0.18%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     93.80%   93.61%   -0.19%     
  Complexity      136      136              
============================================
  Files            20       20              
  Lines           500      501       +1     
  Branches         45       45              
============================================
  Hits            469      469              
- Misses           20       21       +1     
  Partials         11       11
Impacted Files Coverage Δ Complexity Δ
...java/com/batoulapps/adhan/data/DateComponents.java 64.28% <0.00%> (-4.95%) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eefc4ed...1c992d0. Read the comment docs.

ahmedre commented 3 years ago

jazakumAllah khairan for this, but would rather avoid this for now because Android devs who use this without enabling core library desugaring will get unexpected crashes at runtime.

will push a branch in the near future though that will use LocalDate primarily since it will be in KMP, but that will be a parallel version to this version of adhan.