Closed alaa-moataz closed 1 year ago
Thanks for finding this issue - we'll get around to fixing this ourselves but sooner if you would create a PR for this change (with an additional unit test)! We'd appreciate it!
Nice find! Will fix this for both the Java and Kotlin versions probably this weekend (unless @sgtsquiggs gets to it first).
@sgtsquiggs @ahmedre I can create a PR for it today
JazakumAllah khairan
Hello,
Thank you for implementing this library it's really helpful, I noticed one issue is that the milliseconds part of any returned date for prayers can differ given the same Coordinates , Date & CalculationParameters
The code below outputs "Max is 1681351380999 and min is 1681351380000"
I think in your
TimeComponents.java
indateComponents
function you should addcalendar.set(Calendar.MILLISECOND, 0)