search

batoulapps / adhan-kotlin

High precision Islamic prayer time library for Java
MIT License
148 stars 47 forks source link

Implement SunnahTimes and fix tomorrow sunrise #9

Closed ahmedre closed 4 years ago

ahmedre commented 4 years ago

This patch implements SunnahTimes. It also fixes a bug in how the sunrise for the next day was calculated. Instead of computing tomorrow's sunrise from the SolarTime for tomorrow, the code was just adding a day to the previous day's SolarTime. This could cause a 1 minute offset in certain cases. This patch fixes this problem.

codecov[bot] commented 4 years ago

Codecov Report

Merging #9 into master will increase coverage by 1.01%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #9      +/-   ##
=========================================
+ Coverage   94.19%   95.2%   +1.01%     
=========================================
  Files          19      20       +1     
  Lines         482     501      +19     
  Branches       53      53              
=========================================
+ Hits          454     477      +23     
+ Misses         20      16       -4     
  Partials        8       8
Impacted Files Coverage Δ
...rc/main/java/com/batoulapps/adhan/SunnahTimes.java 100% <100%> (ø)
...rc/main/java/com/batoulapps/adhan/PrayerTimes.java 91.52% <87.5%> (+0.29%) :arrow_up:
...java/com/batoulapps/adhan/data/DateComponents.java 100% <0%> (+44.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a16787...704b8a3. Read the comment docs.