batoulapps / adhan-swift

High precision Islamic prayer time library for Swift
MIT License
185 stars 45 forks source link

Prayer Time is not corrent #36

Closed alauthor closed 4 years ago

alauthor commented 4 years ago

in Qatar and Dubai how to use all cases params to make the library get the best result in all cases .

z3bi commented 4 years ago

Can you be more specific? What parameters are you using? What times are you getting vs what you are expecting?

alauthor commented 4 years ago

var params: CalculationParameters = CalculationMethod.moonsightingCommittee.params params.madhab = .shafi This does not work propeply in ( kuwait, qatar, dubai )

alauthor commented 4 years ago

you should handle this via coordinates , you should know in which country the user in and start setting the params

z3bi commented 4 years ago

@alauthor we have a plan to add in a method that can suggest a calculation method for a country, however it will require a two letter country code, since the library won't have geocoding capabilities built into it.

alauthor commented 4 years ago

okay , when this will be done ?

On Fri, Jul 17, 2020 at 4:44 PM Ameir Al-Zoubi notifications@github.com wrote:

@alauthor https://github.com/alauthor we have a plan to add in a method that can suggest a calculation method for a country, however it will require a two letter country code, since the library won't have geocoding capabilities built into it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/batoulapps/adhan-swift/issues/36#issuecomment-660146360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2PKRFLMQ4LXHP4ZO7CRSTR4BPVZANCNFSM4ORMBBUQ .

z3bi commented 4 years ago

@alauthor I don't have a specific date, mostly because a lot of research is needed to make a comprehensive list. The way this can be started is to try and start a list of regions and links to masajid or official prayer times. That will help us to compile the information we need.