search

batstyx / Graveyard

A plugin for the Hearthstone Deck Tracker that displays minions that have died.
35 stars 4 forks source link

Fizzle Snapshot Card order #35

Open G333h opened 7 months ago

G333h commented 7 months ago

Hello ! First, thanks for this plugin, this is what I was looking for fizzle snapshot on HDT, since it's natively missing :) But I noticed cards in fizzle snapshot are in a random order, would it be possible for you to modify it so they are showing in the correct order (from the left to the right in the hand at the moment where it's snapshoted)

Best regards, Thanks

batstyx commented 7 months ago

I played exactly one game to test this change, so good luck to you :)

G333h commented 7 months ago

Hello, thanks !

tested it, it nearly worked as intented, cards are in correct order except when you have 2 copy of a card in the hand, it will group them together.

example with 2 conductivity in my hand

here the correct order was : Novice zapper / kobold geomancer / Bloodmage / conductivity / Flash of lightning / conductivity / crash of thunder / pop-up book and it shows on the plugin Novice zapper / kobold geomancer / Bloodmage / conductivity / conductivity / Flash of lightning / crash of thunder / pop-up book

fizzle

batstyx commented 7 months ago

I really hoped that simple addition would do it. I could have sworn I had duplicate cards correctly ordered in the test I did but the screenshot didn't save for some reason so I can't check. Apart from Demon Hunter Outcast cards, I'm assuming this is mainly a cosmetic annoyance?

G333h commented 7 months ago

Hello ! Sadly, no, it's not cosmetic, order is really important, because you don't often have all the room in your hand to get every card from the snapshot. If I have 8 cards on my snapshot but only 5 spot on my hand and need a precise card which show on 5th spot in the list but is in reality on the 6th spot, it can instantly loose the game.

batstyx commented 7 months ago

Oops. I do, ofc, "know" this, but I'd forgotten. I don't think I've ever played a tight enough strategy that I've lost this way! If I get the time I'll take a further look at this. It may be I'm using the HDT API wrong. However if it's an HDT bug then, unless it's straightforward, it's well above my pay grade.

G333h commented 7 months ago

True, it's for some specific deck/strategy,I admit, it's not for every game :) Thanks, it's allready awesome that you improve the order !

batstyx commented 7 months ago

Related: HearthSim/Hearthstone-Deck-Tracker#4547 HearthSim/Hearthstone-Deck-Tracker#4503